Skip to content

8379620: G1: Typing error in jvmFlagConstraintsG1.cpp#30773

Closed
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
tschatzl:submit/8379620-typo-in-error-message
Closed

8379620: G1: Typing error in jvmFlagConstraintsG1.cpp#30773
tschatzl wants to merge 1 commit intoopenjdk:masterfrom
tschatzl:submit/8379620-typo-in-error-message

Conversation

@tschatzl
Copy link
Copy Markdown
Contributor

@tschatzl tschatzl commented Apr 16, 2026 •
edited by openjdk Bot
Loading

Hi all,

please review this trivial fix of a typo in an error message.

Testing: local compilation

Thanks,
Thomas

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8379620: G1: Typing error in jvmFlagConstraintsG1.cpp (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30773/head:pull/30773
$ git checkout pull/30773

Update a local copy of the PR:
$ git checkout pull/30773
$ git pull https://git.openjdk.org/jdk.git pull/30773/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30773

View PR using the GUI difftool:
$ git pr show -t 30773

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30773.diff

Using Webrev

Link to Webrev Comment

@tschatzl
8379620
be51efb 
Hi all,

  please review this trivial fix of a typo in an error message.

Testing: local compilation

Thanks,
  Thomas
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026 •
edited
Loading

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379620: G1: Typing error in jvmFlagConstraintsG1.cpp

Reviewed-by: iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title 8379620 8379620: G1: Typing error in jvmFlagConstraintsG1.cpp Apr 16, 2026
@openjdk openjdk Bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 16, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 16, 2026

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

walulyai
walulyai approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial!

@tschatzl
Copy link
Copy Markdown
Contributor Author

tschatzl commented Apr 17, 2026

/reviewers 1

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@tschatzl
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 17, 2026
@tschatzl
Copy link
Copy Markdown
Contributor Author

tschatzl commented Apr 17, 2026

Thanks @walulyai for your review.

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

Going to push as commit 787ff67.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 17, 2026
@openjdk openjdk Bot closed this Apr 17, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@tschatzl Pushed as commit 787ff67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8379620-typo-in-error-message branch April 23, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@walulyai walulyai walulyai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tschatzl @walulyai